Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17262 )
Change subject: IMPALA-10642: Write support for Parquet Bloom filters - most common types ...................................................................... Patch Set 19: (6 comments) http://gerrit.cloudera.org:8080/#/c/17262/19/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/17262/19/be/src/exec/parquet/hdfs-parquet-table-writer.cc@708 PS19, Line 708: if (parquet_bloom_filter_state_ == ParquetBloomFilterState::WAIT_FOR_FALLBACK_FROM_DICT) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py File tests/query_test/test_parquet_bloom_filter.py: http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py@122 PS19, Line 122: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py@125 PS19, Line 125: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py@132 PS19, Line 132: T flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py@160 PS19, Line 160: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/17262/19/tests/query_test/test_parquet_bloom_filter.py@162 PS19, Line 162: ; flake8: E703 statement ends with a semicolon -- To view, visit http://gerrit.cloudera.org:8080/17262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie865efd4f0c11b9e111fb94f77d084bf6ee20792 Gerrit-Change-Number: 17262 Gerrit-PatchSet: 19 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jul 2021 14:57:26 +0000 Gerrit-HasComments: Yes
