liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17637 )
Change subject: IMPALA-10766: Better selectivity for =,not distinct ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/17637/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17637/4//COMMIT_MSG@20 PS4, Line 20: Testin > Testing Done http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@253 PS4, Line 253: ! > != Done http://gerrit.cloudera.org:8080/#/c/17637/4/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@283 PS4, Line 283: (numRows - numNulls) / numRows; > nit: I think it's worth to extract it to a variable just like numRows Done -- To view, visit http://gerrit.cloudera.org:8080/17637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ec62f2355a7036125cc0d261b790644b9f4b60 Gerrit-Change-Number: 17637 Gerrit-PatchSet: 5 Gerrit-Owner: liuyao <liu...@sensorsdata.cn> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: liuyao <liu...@sensorsdata.cn> Gerrit-Comment-Date: Fri, 09 Jul 2021 09:52:41 +0000 Gerrit-HasComments: Yes
