Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17667 )
Change subject: IMPALA-10784: Add support for retaining cookies in impala-shell ...................................................................... IMPALA-10784: Add support for retaining cookies in impala-shell IMPALA-10234 added support for cookie authentication for LDAP to impala-shell. But it does not accept user input cookie name via startup flags, and it retains only one cookie. In some scenarios, we could use proxy to manage the sessions with additional HTTP cookies added by proxy. This patch made cookie support more generic for impala-shell. It lets the user specify cookie names via a startup flag "--http_cookie_names" and could retain more than one cookies. Testing: - Manualy tested the multiple cookies in HTTP headers with a customized Impala server which could send and receive multiple cookies. - Passed core test, including new test cases. Change-Id: I193422d5ec891886a522d82ecb0e9d974132ff2a --- M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java M shell/ImpalaHttpClient.py M shell/cookie_util.py M shell/impala_client.py M shell/impala_shell.py M shell/option_parser.py M tests/shell/test_cookie_util.py 7 files changed, 131 insertions(+), 67 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/17667/4 -- To view, visit http://gerrit.cloudera.org:8080/17667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I193422d5ec891886a522d82ecb0e9d974132ff2a Gerrit-Change-Number: 17667 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
