Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17503 )
Change subject: IMPALA-10771: Add Tencent COS support ...................................................................... Patch Set 4: Separately, I looked at the hadoop-cos repository here: https://github.com/tencentyun/hadoop-cos One problem is that there is no license specified for the hadoop-cos code as far as I can see. Apache Impala wants its dependencies to be compatible with the Apache License 2.0. If you have control over that repository, it would be useful to add a LICENSE.txt file that declares it as Apache 2.0 licensed (or some other Apache 2.0 compatible license). See this file in Apache Hadoop for an example. https://github.com/apache/hadoop/blob/trunk/LICENSE.txt More information here: https://www.apache.org/licenses/LICENSE-2.0 -- To view, visit http://gerrit.cloudera.org:8080/17503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idce135a7591d1b4c74425e365525be3086a39821 Gerrit-Change-Number: 17503 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 13 Jul 2021 23:46:05 +0000 Gerrit-HasComments: No
