Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17663 )
Change subject: IMPALA-10489 part2: Support RSASSA-PSS and EC Algorithms for JWT ...................................................................... Patch Set 2: Code-Review+2 (1 comment) This looks good. Thanks! http://gerrit.cloudera.org:8080/#/c/17663/1/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/17663/1/be/src/util/jwt-util.cc@313 PS1, Line 313: if (algorithm == "rs256") { : jwt_pub_key = new RS256JWTPublicKey(algorithm, pub_key); : } else if (algorithm == "rs384") { : jwt_pub_key = new RS384JWTPublicKey(algorithm, pub_key); : } else if (algorithm == "rs512") { : jwt_pub_key = new RS512JWTPublicKey(algorithm, pub_key); : } else if (algorithm == "ps256") { : jwt_pub_key = new PS256JWTPublicKey(algorithm, pub_key); : } else if (algorithm == "ps384") { : jwt_pub_key = new PS384JWTPublicKey(algorithm, pub_key); : } else if (algorithm == "ps512") { : jwt_pub_key = new PS512JWTPublicKey(algorithm, pub_key); > replaced compare() with "==". Tried "switch" for string, but got compiling Oh, I must have been thinking of a different language. -- To view, visit http://gerrit.cloudera.org:8080/17663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4dc30c51f503b609dd311ce4387080abc5a0832 Gerrit-Change-Number: 17663 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 15 Jul 2021 03:48:38 +0000 Gerrit-HasComments: Yes
