Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17654 )
Change subject: IMPALA-10627: Use standard parquet-related Iceberg table properties ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/17654/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/17654/6/be/src/exec/parquet/hdfs-parquet-table-writer.cc@1150 PS6, Line 1150: : columns_.resize(num_co > Now the implementation of these could be moved to Configure()/ConfigureForI Done http://gerrit.cloudera.org:8080/#/c/17654/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/17654/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@325 PS6, Line 325: able.getParameters(); > For backward compatibility we might also want to search for "iceberg.file_f Done -- To view, visit http://gerrit.cloudera.org:8080/17654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b8aa9a52c13c41b48310d2f7c9c7426e1ff5f23 Gerrit-Change-Number: 17654 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 16 Jul 2021 14:11:48 +0000 Gerrit-HasComments: Yes
