Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/17660/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17660/3/shell/impala_client.py@1091 PS3, Line 1091: resp = self._do_hs2_rpc(CloseOperation, retry_on_error=True) Not sure if we should retry here. The only case that is worth retrying is if there was a transport error but the session is still alive. I realize this is copied but the backend may have different error states. http://gerrit.cloudera.org:8080/#/c/17660/3/shell/impala_shell_config_defaults.py File shell/impala_shell_config_defaults.py: http://gerrit.cloudera.org:8080/#/c/17660/3/shell/impala_shell_config_defaults.py@58 PS3, Line 58: 'strict_protocol': False, strict_hs2_protocol http://gerrit.cloudera.org:8080/#/c/17660/3/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/17660/3/shell/option_parser.py@280 PS3, Line 280: parser.add_option("--strict_protocol", dest="strict_protocol", action="store_true", strict_hs2_protocol. Make it clear this only applies to HS2. http://gerrit.cloudera.org:8080/#/c/17660/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/17660/3/tests/shell/test_shell_interactive.py@193 PS3, Line 193: if vector.get_value('strict_protocol') and vector.get_value('protocol') == 'beeswax': May be cleaner to split the tests into 2 vectors. http://gerrit.cloudera.org:8080/#/c/17660/3/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/17660/3/tests/shell/util.py@318 PS3, Line 318: f = open('/home/steve/tmp/sjc24.txt', 'w') change hard-coded path. -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 19 Jul 2021 17:44:13 +0000 Gerrit-HasComments: Yes
