Sourabh Goyal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17703 )

Change subject: [WIP]: Initial commit to acquire table/database lock in 
metastore server before any HMS operation
......................................................................


Patch Set 3:

Requesting an early review on the approach.

Sharing few details on the approach taken:

All HMS APIs for which we need to sync to the latest envent id are overriden in 
CatalogMetastoreServiceHandler. If either enableCatalogdHMSCache or 
syncToLatestEventId flag is false, we fallback to pass through api in 
MetastoreServiceHandler.

One api to look into is exchange_partition for which we need to take lock on 
both source and destination table atomically. Since there was no api in 
CatalogServiceCatalog for acquiring lock on multiple tables, I defined one in 
this patch.

Please review it and share your feedback. Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/17703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I085eab20db61282daf4549ddbcc018aaf63cc361
Gerrit-Change-Number: 17703
Gerrit-PatchSet: 3
Gerrit-Owner: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jul 2021 11:16:48 +0000
Gerrit-HasComments: No

Reply via email to