Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17707 )
Change subject: IMPALA-10815: Ignore events on non-default hive catalogs ...................................................................... Patch Set 4: Code-Review+1 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/17707/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/17707/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@231 PS4, Line 231: && catalog_.isBlacklistedTable(eventDb, eventTbl))) { Should we include a check for catalogName here as well? So we don't log this message if the db/tbl belongs to a different catalog. Or probably we should just do the catalog check first. http://gerrit.cloudera.org:8080/#/c/17707/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/17707/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@367 PS4, Line 367: if (MetastoreShim.getMajorVersion() >= 2) { We dropped support for Hive 2, so it will always be true. -- To view, visit http://gerrit.cloudera.org:8080/17707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ided463b2a98331d3d305bbe92fbf3a5d2e197acf Gerrit-Change-Number: 17707 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 21 Jul 2021 16:58:44 +0000 Gerrit-HasComments: Yes
