Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15898 )
Change subject: IMPALA-8680: Docker-based tests fail to archive the minicluster component logs ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15898/6/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/15898/6/docker/entrypoint.sh@304 PS6, Line 304: copy_cluster_logs One thing I noticed when I ran this is that this code doesn't execute if any of the commands above fail. That must be because we use "set -e" when executing these functions. One way to fix that would be to follow the structure that test_suite() uses. In other words: ret = 0 if ! ./buildall.sh -noclean -format -testdata -notests; then ret = 1 echo "Build + dataload failed!" else echo "Build + dataload succeeded!" fi Then, below that point, use ret to decide what needs to do. If ret is 0, then do all the current steps. If ret is 1, skip building parquet-reader/impala-profile-tool and the hardlinking duplicate HDFS blocks, but otherwise do basically the same things. It looks like test_suite() uses a lot of "cmd || true" structure to avoid exiting, then it returns ret at the end. -- To view, visit http://gerrit.cloudera.org:8080/15898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23e25d42992cec47c593dc388bcf0bcef828c05e Gerrit-Change-Number: 15898 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Garaguly <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Zoltan Garaguly <[email protected]> Gerrit-Comment-Date: Thu, 22 Jul 2021 03:34:28 +0000 Gerrit-HasComments: Yes
