liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17645 )
Change subject: IMPALA-5476: Fix Catalogd restart bring about metadata is out of sync ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/17645/7/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17645/7/be/src/service/impala-server.cc@a2142 PS7, Line 2142: > Can we keep this? If we wait for the next statestore update, this won't cau Done http://gerrit.cloudera.org:8080/#/c/17645/7/be/src/service/impala-server.cc@2144 PS7, Line 2144: TUniqueId cur_service_id; > Could you add a log before the while-loop? E.g. Done http://gerrit.cloudera.org:8080/#/c/17645/7/be/src/service/impala-server.cc@2150 PS7, Line 2150: << ".ID in response:" << catalog_service_id << ". Catalogd may be restarted." > I think this captures the case that catalogd restart again and we get anoth The previous catalog service ID was not recorded, so I printed expected catalog service ID http://gerrit.cloudera.org:8080/#/c/17645/7/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/17645/7/tests/custom_cluster/test_restart_services.py@169 PS7, Line 169: def test_restart_catalogd(self): > This is already a good test case. Can we add another one to cover the case Done -- To view, visit http://gerrit.cloudera.org:8080/17645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe25f5a2a42fb432e306ef08ae35750c8f3c50c Gerrit-Change-Number: 17645 Gerrit-PatchSet: 10 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Thu, 22 Jul 2021 10:11:24 +0000 Gerrit-HasComments: Yes
