Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17660/5/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17660/5/shell/impala_client.py@1102 PS5, Line 1102: # CloseImpalaOperation rpc is idempotent for non dml queries and so safe to retry. Comment doesn't match retry flag. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_commandline.py@360 PS5, Line 360: if vector.get_value('strict_hs2_protocol'): nit: this could be in a function to avoid duplication. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py@352 PS5, Line 352: pytest.skip("Failed, need to investigate.") Please file a JIRA and reference here if you want to leave this TODO. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py@518 PS5, Line 518: pytest.skip("Not working in strict hs2 mode.") Another TODO JIRA? Several more below. http://gerrit.cloudera.org:8080/#/c/17660/5/tests/shell/test_shell_interactive.py@1092 PS5, Line 1092: pytest.skip("The now() function is not supported in strict hs2 mode.") Is this an impala-shell limitation or a frontend limitation? -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 22 Jul 2021 17:57:39 +0000 Gerrit-HasComments: Yes
