liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17645 )
Change subject: IMPALA-5476: Fix Catalogd restart bring about metadata is out of sync ...................................................................... Patch Set 13: (6 comments) http://gerrit.cloudera.org:8080/#/c/17645/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17645/10/be/src/service/impala-server.cc@2150 PS10, Line 2150: g_version_update > nit: add a space after "." and ":" Done http://gerrit.cloudera.org:8080/#/c/17645/10/be/src/service/impala-server.cc@2167 PS10, Line 2167: > nit: add a space after each ":" Done http://gerrit.cloudera.org:8080/#/c/17645/10/be/src/service/impala-server.cc@2168 PS10, Line 2168: ocess the catalog update that covers the effects : // (catalog objects) of this o > nit: we can remove this if it's logging the same id. Done http://gerrit.cloudera.org:8080/#/c/17645/10/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/17645/10/tests/custom_cluster/test_restart_services.py@186 PS10, Line 186: self.execute_query_expect_success(self.client, : "alter table join_aa add columns (name string)") > Could you add another test with this being executed with sync_ddl=true? Jus Done http://gerrit.cloudera.org:8080/#/c/17645/10/tests/custom_cluster/test_restart_services.py@208 PS10, Line 208: LOG.info(str(e)) : if i == 5: : self.cluster.catalogd.restart() : > I ran this test several times but I'm not able to see the WARNING log of "I I tried many times, but the WARNING log was not printed. It may be because of the following reason: after catalogd restarts successfully for the second time, catalogd will not immediately notify statestored to clear catalog topic entries. After waiting for "statestore_update_frequency_ms" milliseconds, catalogd receives the update request from statestored, and then catalogd notifies statestored to clear the catalog topic entries. Therefore, impalad has enough time to complete the first full update, which is triggered by the first restart of catalogd. http://gerrit.cloudera.org:8080/#/c/17645/10/tests/custom_cluster/test_restart_services.py@223 PS10, Line 223: Make the catalog object ve > nit: rename to "test_restart_catalogd_with_local_catalog" Done -- To view, visit http://gerrit.cloudera.org:8080/17645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe25f5a2a42fb432e306ef08ae35750c8f3c50c Gerrit-Change-Number: 17645 Gerrit-PatchSet: 13 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Mon, 26 Jul 2021 06:05:00 +0000 Gerrit-HasComments: Yes
