Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17712 )
Change subject: IMPALA-10806: Create single node plan slowdown when hundreds of inline views are joined ...................................................................... Patch Set 3: (2 comments) Looks very good. Just wonder if we could add a query test to safe guard the reduction in compilation time. http://gerrit.cloudera.org:8080/#/c/17712/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17712/2//COMMIT_MSG@29 PS2, Line 29: Testing: > I didn't find the right place to add tests and add a repro query here nit. I wonder if the query mentioned in the commit message can be used as the test query, with an assertion of "Single node plan created" from profile to be less than 1.5s? http://gerrit.cloudera.org:8080/#/c/17712/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/17712/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1218 PS2, Line 1218: pr> nullableR > I think there is not a way to know the trimming is beneficial in advance, b Done -- To view, visit http://gerrit.cloudera.org:8080/17712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4011b6167a0e61438a73c4dba6f1cd0a4e8c6a Gerrit-Change-Number: 17712 Gerrit-PatchSet: 3 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Tue, 27 Jul 2021 12:53:19 +0000 Gerrit-HasComments: Yes
