Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 )
Change subject: IMPALA-8762: Track host level admission stats across all coordinators ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17683/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/17683/2/be/src/scheduling/admission-controller.cc@257 PS2, Line 257: << "All admission topic key prefixes should be of the same size"; > Nit: "All admission topic keys" is better, as this may make it clearer for Done http://gerrit.cloudera.org:8080/#/c/17683/2/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/17683/2/tests/custom_cluster/test_executor_groups.py@573 PS2, Line 573: # identical but this will at least test that code path as a sanity check. > Nit: "at least" "code path" Done -- To view, visit http://gerrit.cloudera.org:8080/17683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2946832e0a89b077d0f3bec755e4672be2088243 Gerrit-Change-Number: 17683 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Jul 2021 23:22:30 +0000 Gerrit-HasComments: Yes
