Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17736 )
Change subject: [WIP]: Initial commit to use metastoreEventFactory in CatalogOpExecutor to sync to latest event id ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@888 PS1, Line 888: metastoreEventsMetrics_.addTimer(MetastoreEventsProcessor.EVENTS_FETCH_DURATION_METRIC); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@889 PS1, Line 889: metastoreEventsMetrics_.addTimer(MetastoreEventsProcessor.EVENTS_PROCESS_DURATION_METRIC); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@892 PS1, Line 892: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_TABLE_REFRESHES); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@893 PS1, Line 893: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_PARTITION_REFRESHES); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@896 PS1, Line 896: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_DATABASES_ADDED); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@897 PS1, Line 897: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_DATABASES_REMOVED); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@898 PS1, Line 898: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_PARTITIONS_ADDED); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17736/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@899 PS1, Line 899: metastoreEventsMetrics_.addCounter(MetastoreEventsProcessor.NUMBER_OF_PARTITIONS_REMOVED); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5a6dbf93c688c4af5bbb2976fcc2b40c78cbc40 Gerrit-Change-Number: 17736 Gerrit-PatchSet: 1 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 29 Jul 2021 12:45:44 +0000 Gerrit-HasComments: Yes
