Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 )
Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header ...................................................................... Patch Set 1: (1 comment) Looks good, Andrew's covered most of the stuff, just one more nit from my side http://gerrit.cloudera.org:8080/#/c/17759/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/17759/1/be/src/util/webserver.cc@907 PS1, Line 907: bool Webserver::HandleTrustedAuthHeader( : struct sq_connection* connection, struct sq_request_info* request_info) { : string err_msg; : if (!GetUsernameFromAuthHeader(connection, request_info, err_msg)) { : LOG(ERROR) << "Found trusted auth header but " << err_msg; : return false; : } : return true; : } nit: you can just get rid of HandleTrustedAuthHeader if you are only calling GetUsernameFromAuthHeader. -- To view, visit http://gerrit.cloudera.org:8080/17759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7103012bc9cf9dfdc9c184af3a281526d8127a31 Gerrit-Change-Number: 17759 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 00:30:12 +0000 Gerrit-HasComments: Yes
