Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17576 )
Change subject: IMPALA-10746: Drop table/db from catalog cache when drop table/db HMS apis are accessed from catalog's metastore server. ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/17576/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17576/17/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2967 PS17, Line 2967: ame); : org.apache.impala.cat > nit, can go in the same line above. I would suggest you to have your IDE se Thanks for sharing the style link. The formatting got messed up in the last conflict resolution. Will fix it. http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@861 PS18, Line 861: msDb > pls update the java doc Sorry, I missed it. Thanks for pointing it out. http://gerrit.cloudera.org:8080/#/c/17576/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@865 PS18, Line 865: String dbName > this can go into the above line now. Ack -- To view, visit http://gerrit.cloudera.org:8080/17576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e2ad2630e2028b8ad26a6272ee766b27e0935c Gerrit-Change-Number: 17576 Gerrit-PatchSet: 18 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Aug 2021 16:54:06 +0000 Gerrit-HasComments: Yes
