liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17645 )
Change subject: IMPALA-5476: Fix Catalogd restart bring about metadata is out of sync ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/17645/16/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17645/16/be/src/service/impala-server.cc@2129 PS16, Line 2129: TUniqueId cur_service_id; : { : unique_lock<mutex> ver_lock(catalog_version_lock_); : cur_service_id = catalog_update_info_.catalog_service_id; : if (catalog_update_info_.catalog_service_id != catalog_service_id) { : LOG(INFO) << "Catalog service ID mismatch. Current ID: " : << PrintId(cur_service_id) << ". ID in response: " : << PrintId(catalog_service_id) << ". Catalogd may be restarted. Waitin > nit: Let's move these into the if-clause at line 2155. Done http://gerrit.cloudera.org:8080/#/c/17645/16/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/17645/16/tests/custom_cluster/test_restart_services.py@217 PS16, Line 217: 10 > nit: Can we lower this down to 5? Done. down to 10 http://gerrit.cloudera.org:8080/#/c/17645/16/tests/custom_cluster/test_restart_services.py@239 PS16, Line 239: sleep(self.UPDATE_FREQUENCY_S * 2) > While thinking about comments for this sleep, I realize this actually revea If the service id is monotonically increasing, then this problem is better solved. But the service id is not, maybe we can treat it as a todo -- To view, visit http://gerrit.cloudera.org:8080/17645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe25f5a2a42fb432e306ef08ae35750c8f3c50c Gerrit-Change-Number: 17645 Gerrit-PatchSet: 17 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Mon, 16 Aug 2021 03:19:11 +0000 Gerrit-HasComments: Yes
