Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/17660/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17660/8//COMMIT_MSG@22 PS8, Line 22: authentication) should work as well. > Sorry, took awhile for me to get back. There are some authentication related shell tests that are called from "custom cluster FE tests" like https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/customcluster/LdapSearchBindImpalaShellTest.java It sets up a test ldap server in Java than runs impala-shell processes to verify that it behaves as expected. It could be potentially modified to try it with both strict and normal hs2. test_ldap_password_from_shell only tests failed authentication, as there is no LDAP server running, see https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/tests/shell/test_shell_commandline.py#L668 But my main concern is actually different: all these tests connect to Impala, not Hive, so we cannot say that we have tested secure connections to Hive with impala-shell. So I think that we should note that these would probably work, but we didn't verify this. There can be subtle differences in Impala/Hive auth workflow (for example the name of the auth cookie as I mentioned earlier in another comment) -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 16 Aug 2021 15:12:38 +0000 Gerrit-HasComments: Yes
