Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17768 )

Change subject: IMPALA-10783: Fixed flakiness in 
run_and_verify_query_cancellation_test
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17768/1/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/17768/1/tests/shell/test_shell_commandline.py@387
PS1, Line 387:     try:
> Having this line in the try block doesn't seem useful to me, as the finally
Done


http://gerrit.cloudera.org:8080/#/c/17768/1/tests/shell/test_shell_commandline.py@423
PS1, Line 423:
> Same as line 387
Done



--
To view, visit http://gerrit.cloudera.org:8080/17768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6d22d639921051cde5675fae1845bedb61c8cc
Gerrit-Change-Number: 17768
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Comment-Date: Tue, 17 Aug 2021 00:55:42 +0000
Gerrit-HasComments: Yes

Reply via email to