Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17780 )
Change subject: IMPALA-9662,IMPALA-2019(part-4): Support UTF-8 mode in mask functions ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10658 PS1, Line 10658: TestStringValue("mask_show_first_n('hello李小龙', 6, 'x', 'x', 'x', 'X')", "hello李XX"); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10660 PS1, Line 10660: TestStringValue("mask_show_first_n('hello李小龙', 4, 'x', 'x', 'x', 'X')", "hellxXXX"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10664 PS1, Line 10664: TestStringValue("mask_first_n('hello李小龙', 6, 'x', 'x', 'x', 'X')", "xxxxxX小龙"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10665 PS1, Line 10665: TestStringValue("mask_show_last_n('hello李小龙', 2, 'x', 'x', 'x', 'X')", "xxxxxX小龙"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10666 PS1, Line 10666: TestStringValue("mask_show_last_n('hello李小龙', 4, 'x', 'x', 'x', 'X')", "xxxxo李小龙"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10668 PS1, Line 10668: // Test masking to unicode code points. Specify -1(unmask) for masking upper/lower/digit chars. line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10670 PS1, Line 10670: TestStringValue("mask_last_n('hello李小龙', 4, -1, -1, -1, '某')", "hello某某某"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10671 PS1, Line 10671: TestStringValue("mask_last_n('hello李小龙', 2, -1, -1, -1, '某')", "hello李某某"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10672 PS1, Line 10672: TestStringValue("mask_show_first_n('hello李小龙', 4, -1, -1, -1, '某')", "hello某某某"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10673 PS1, Line 10673: TestStringValue("mask_show_first_n('hello李小龙', 6, -1, -1, -1, '某')", "hello李某某"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10674 PS1, Line 10674: TestStringValue("mask_first_n('李小龙hello', 4, -1, -1, -1, '某')", "某某某hello"); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/expr-test.cc@10675 PS1, Line 10675: TestStringValue("mask_show_last_n('李小龙hello', 5, -1, -1, -1, '某')", "某某某hello"); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17780/1/be/src/exprs/mask-functions-ir.cc@125 PS1, Line 125: c = MaskTransform(c, masked_upper_char, masked_lower_char, masked_digit_char, masked_other_char); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1276eccc94c9528507349b155a51e76f338367d5 Gerrit-Change-Number: 17780 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Aug 2021 03:07:09 +0000 Gerrit-HasComments: Yes
