Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17778
Change subject: IMPALA-10862 Optimization of the code structure of TmpDir ...................................................................... IMPALA-10862 Optimization of the code structure of TmpDir Currently the logic of initialization of TmpFileMgr is a bit tedious, this patch optimizes the code structure of TmpDir to have directory parsing and validation logic to simplify the TmpFileMgr InitCustom(). This patch also adds TmpDirLocal, TmpDirHdfs and TmpDirS3 to inherit TmpDir to implement their own logic to parse and validate, in this way, the code is easier to add more custom logic for other filesystems in future. All changes only affect the interfaces within the TmpFileMgr module, and the main directory parsing and verification logic don't change. Because the current testcases of TmpFileMgrTest already cover the TmpDir parsing and verification, no testcases may need to be added. Tests: Ran the Core tests and exhaustive e2e tests. Change-Id: I52971238d5841a1cdfee06b38750f9dc99a6a2be --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h 4 files changed, 429 insertions(+), 326 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/17778/1 -- To view, visit http://gerrit.cloudera.org:8080/17778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I52971238d5841a1cdfee06b38750f9dc99a6a2be Gerrit-Change-Number: 17778 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]>
