Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17772 )

Change subject: IMPALA-10857: Add curl 7.78.0 to native-toolchain
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

LGTM. BTW, did you verify that curl 7.78.0 satifies IMPALA-10853? in case we 
need some additional patches.

http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh
File source/curl/build.sh:

http://gerrit.cloudera.org:8080/#/c/17772/1/source/curl/build.sh@33
PS1, Line 33: --with-openssl
Good to see this! I think this also helps to resolve IMPALA-10853. Maybe we can 
let cmake build on top of this curl in future patch.



--
To view, visit http://gerrit.cloudera.org:8080/17772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab535ef20abb9790056ec22015f8d6d8d33cef6d
Gerrit-Change-Number: 17772
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:18:13 +0000
Gerrit-HasComments: Yes

Reply via email to