Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17638 )
Change subject: WiP: IMPALA-9495: Support struct in select list for ORC tables ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/17638/4/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/17638/4/be/src/runtime/raw-value.cc@223 PS4, Line 223: DCHECK(value != nullptr && tuple != nullptr && slot_desc != nullptr && > I think it is always better to check inside the function than check in the Or at least we could add a DCHECK. http://gerrit.cloudera.org:8080/#/c/17638/3/be/src/udf/udf.h File be/src/udf/udf.h: http://gerrit.cloudera.org:8080/#/c/17638/3/be/src/udf/udf.h@747 PS3, Line 747: > The reason I didn't use std::vector (even though it would have been way mor Thanks. Also now that we use custom allocation using a vector would probably not be easier. -- To view, visit http://gerrit.cloudera.org:8080/17638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbe56bdcd372b72e99c0195d87a818e7fa4bc3a Gerrit-Change-Number: 17638 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 19 Aug 2021 09:07:24 +0000 Gerrit-HasComments: Yes
