Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17592 )
Change subject: IMPALA-7635: Reducing HashTable size by packing it's buckets efficiently. ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17592/12/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/17592/12/be/src/exec/hash-table.h@705 PS12, Line 705: If bucket doesn't have tag fields set, TAGGED can : /// be set to 'false' to avoid extra bit operations. > 'IF' is upon boolean template parameter, so compiler will do dead branch e Okay on dead branch elimination. On comment for TAGGED, I think it is still a good idea to add it to the class level description, as I saw duplication of comments on the same topic. -- To view, visit http://gerrit.cloudera.org:8080/17592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72912ae9353b0d567a976ca712d2d193e035df9b Gerrit-Change-Number: 17592 Gerrit-PatchSet: 12 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 24 Aug 2021 15:08:25 +0000 Gerrit-HasComments: Yes
