Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17765 )
Change subject: IMPALA-10840: Add support for "FOR SYSTEM_TIME AS OF" and "FOR SYSTEM_VERSION AS OF" for Iceberg tables ...................................................................... Patch Set 6: (1 comment) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/17765/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/17765/5/tests/query_test/test_iceberg.py@116 PS5, Line 116: def test_time_travel(self, vector, unique_database): > One more case that can be added to JIRA above is time travel's behaviour wi With Iceberg V1 we can only query the old snapshot with the current schema. With V2 it's possible to retrieve the older schema: https://github.com/apache/iceberg/issues/1029 I opened a Jira for this subject: IMPALA-10893 Interestingly MS SQL SERVER also uses the current table schema for time travel queries: http://sqlfiddle.com/#!18/42e613/2/0 -- To view, visit http://gerrit.cloudera.org:8080/17765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib523c5e47b8d9c377bea39a82fe20249177cf824 Gerrit-Change-Number: 17765 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 27 Aug 2021 16:35:35 +0000 Gerrit-HasComments: Yes
