Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 11: (10 comments) Thank Qifan and Zoltan for reviewing this revived patch! * Addressed comments. * Fixed planner test failure. * Filed IMPALA-10894 to follow up the issue of "original files". http://gerrit.cloudera.org:8080/#/c/15403/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15403/9//COMMIT_MSG@13 PS9, Line 13: min/max predicate pushdown > Is there a plan to pushdown equality predicates as well? They could be eval Yeah, it's targeted on a follow-up JIRA: IMPALA-10873 http://gerrit.cloudera.org:8080/#/c/15403/9//COMMIT_MSG@20 PS9, Line 20: predicate pushdown will take effect, otherwise it will be skipped. The > Could you mention that at what level the predicates are evaluated? I believ Done. Added a test on tpch_orc_def.lineitem table which has one ORC file with many stripes and row groups. http://gerrit.cloudera.org:8080/#/c/15403/9//COMMIT_MSG@32 PS9, Line 32: > verify? Done http://gerrit.cloudera.org:8080/#/c/15403/9//COMMIT_MSG@36 PS9, Line 36: : - Run TPCH > Could you please provide an example? Done http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/hdfs-orc-scanner.h File be/src/exec/hdfs-orc-scanner.h: http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/hdfs-orc-scanner.h@181 PS9, Line 181: sear > I'm not sure I understand the name of this pool. 'search_args_pool_' maybe? Sure. Renamed this since it confused both Qifan and Zoltan... http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/hdfs-orc-scanner.h@183 PS9, Line 183: lifetime > nit: lifetime Done http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/hdfs-orc-scanner.h@333 PS9, Line 333: with the assu > nit: 'with the assumption'? Done http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/orc-metadata-utils.h File be/src/exec/orc-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/15403/9/be/src/exec/orc-metadata-utils.h@51 PS9, Line 51: Status ResolveColumn(const SchemaPath& col_path, const orc::Type** node, > This line is not true anymore. Done http://gerrit.cloudera.org:8080/#/c/15403/9/tests/query_test/test_orc_stats.py File tests/query_test/test_orc_stats.py: http://gerrit.cloudera.org:8080/#/c/15403/9/tests/query_test/test_orc_stats.py@42 PS9, Line 42: > This means that the MT_DOP values are ignored. Oops, removed MT_DOP_VALUES http://gerrit.cloudera.org:8080/#/c/15403/10/tests/query_test/test_orc_stats.py File tests/query_test/test_orc_stats.py: http://gerrit.cloudera.org:8080/#/c/15403/10/tests/query_test/test_orc_stats.py@18 PS10, Line 18: from tests.common.impala_test_suite import ImpalaTestSuite > flake8: F401 'tests.common.test_vector.ImpalaTestDimension' imported but un Done -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 11 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 29 Aug 2021 11:34:04 +0000 Gerrit-HasComments: Yes
