Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17820 )
Change subject: IMPALA-10896: Fix impala shell tests on S3 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/17820/1/tests/shell/test_shell_commandline.py@141 PS1, Line 141: cls.ImpalaTestMatrix.add_dimension(create_client_protocol_strict_dimension()) Another option is to add a condition about whether you call this or create_client_protocol_no_strict_dimension(). i.e. if IS_HDFS: ...add_dimension(create_client_protocol_strict_dimension()) else: ...add_dimension(create_client_protocol_no_strict_dimension()) This could also be put inside create_client_protocol_strict_dimension() itself (i.e. it looks at IS_HDFS and returns the right thing). -- To view, visit http://gerrit.cloudera.org:8080/17820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e09731e5edebb9107edfa53fd0c53671fe64b4 Gerrit-Change-Number: 17820 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 07 Sep 2021 18:39:52 +0000 Gerrit-HasComments: Yes
