Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 )
Change subject: WIP IMPALA-6636: Use async IO in ORC scanner ...................................................................... Patch Set 8: (18 comments) http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc File be/src/exec/hdfs-columnar-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@153 PS8, Line 153: //LOG(INFO) << "reservation_to_distribute: " << reservation_to_distribute << "reserved: " << min_buffer_size * col_range_lengths.size(); line too long (138 > 90) http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@158 PS8, Line 158: LOG(INFO) << "col_range_lengths: " << col_range_lengths[i]; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@160 PS8, Line 160: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@172 PS8, Line 172: //LOG(INFO) << "reservation_to_distribute: " << reservation_to_distribute << line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@172 PS8, Line 172: //LOG(INFO) << "reservation_to_distribute: " << reservation_to_distribute << tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@203 PS8, Line 203: //LOG(INFO) << "reservation_to_distribute: " << reservation_to_distribute << " bytes to add " << bytes_to_add; line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@203 PS8, Line 203: //LOG(INFO) << "reservation_to_distribute: " << reservation_to_distribute << " bytes to add " << bytes_to_add; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-columnar-scanner.cc@209 PS8, Line 209: LOG(INFO) << "column reservation: " << tmp_reservation.second; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@112 PS8, Line 112: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@113 PS8, Line 113: //LOG(INFO) << "Read random from orc. offset: " << offset << " length: " << length; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@124 PS8, Line 124: //LOG(INFO) << "Read async orc. offset: " << offset << " length: " << length; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@145 PS8, Line 145: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@198 PS8, Line 198: unique_ptr<orc::StreamInformation> stream = stripe.getStreamInformation(stream_id); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@269 PS8, Line 269: DCHECK(false); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@280 PS8, Line 280: return status; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@281 PS8, Line 281: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@282 PS8, Line 282: //LOG(INFO) << "HdfsOrcScanner::ColumnRange::read skipping: " << (offset - position_); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15370/8/be/src/exec/hdfs-orc-scanner.cc@295 PS8, Line 295: //LOG(INFO) << "HdfsOrcScanner::ColumnRange::read stream finished: "; tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/15370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I348ad9e55f0cae7dff0d74d941b026dcbf5e4074 Gerrit-Change-Number: 15370 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 09 Sep 2021 18:45:43 +0000 Gerrit-HasComments: Yes
