Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 )
Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ...................................................................... Patch Set 12: Code-Review+2 (3 comments) Sounds like a good plan. +1 for me and +2 to include Csaba's +1. http://gerrit.cloudera.org:8080/#/c/15403/11/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15403/11/be/src/exec/hdfs-orc-scanner.cc@1053 PS11, Line 1053: const TupleDescriptor* min_max_tuple_desc = scan_node_->min_max_tuple_desc(); : if (!min_max_tuple_desc) return Status::OK(); : // TODO(IMPALA-10894): pushing down predicates into the ORC reader wi > > Since HdfsOrcScanner operates at the thread level, the work here (all the Sounds good to me. http://gerrit.cloudera.org:8080/#/c/15403/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/15403/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@575 PS11, Line 575: addMinMaxOriginalConjunct(slotDesc.getParent(), binaryPred); : buildStatsPredicate(analyzer, slotRef, binaryPred, binaryPred.getOp()); : } else if (BinaryPredicate.IS_EQ_PREDICATE.apply(binaryPred)) { : addMinMaxOriginalConjunct(slotDesc.getParent(), binaryPred); : // TODO: this could be optimized for boolean columns. : > Yeah, this will be done in the next patch: https://gerrit.cloudera.org/c/17 Okay. http://gerrit.cloudera.org:8080/#/c/15403/11/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@581 PS11, Line 581: buildStatsPredicate(analyzer, slotRef, binaryPred, BinaryPredicate.Operator.GE); > Yeah, same as the above reply. Done -- To view, visit http://gerrit.cloudera.org:8080/15403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136622413db21e0941d238ab6aeea901a6464845 Gerrit-Change-Number: 15403 Gerrit-PatchSet: 12 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Anonymous Coward (520) Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Sep 2021 18:29:09 +0000 Gerrit-HasComments: Yes
