Alexander Saydakov has posted comments on this change. ( http://gerrit.cloudera.org:8080/17744 )
Change subject: IMPALA-10835: Extend the DS_HLL_SKETCH function to accept a precision ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17744/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17744/1/be/src/exprs/aggregate-functions-ir.cc@1826 PS1, Line 1826: datasketches why max here, not the specified precision? -- To view, visit http://gerrit.cloudera.org:8080/17744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91a360bb046d4abb101641772b6159308bf6c014 Gerrit-Change-Number: 17744 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Alexander Saydakov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Sep 2021 21:38:14 +0000 Gerrit-HasComments: Yes
