Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17802 )
Change subject: IMPALA-10876: Support to download JWKS from given URL ...................................................................... Patch Set 6: Code-Review+2 (1 comment) This change is looking good to me. I have one nit, but this looks ready to go otherwise. http://gerrit.cloudera.org:8080/#/c/17802/6/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/17802/6/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@89 PS6, Line 89: String srcJwksFilename = : new File(System.getenv("IMPALA_HOME"), "testdata/jwt/jwks_rs256.json").getPath(); : String dstJwksFilename = : new File(System.getenv("IMPALA_HOME"), "www/jwks_test.json").getPath(); : List<String> command = : Lists.newArrayList(Arrays.asList("cp", srcJwksFilename, dstJwksFilename)); : RunShellCommand.Run(command.toArray(new String[0]), /*shouldSucceed*/ true, "", ""); Nit: It would be nice to use native Java methods to avoid dropping down to shell. It looks like Java's java.nio.file.Files has the methods we need: https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html This comment applies here and the other copy and remove below. TestRequestPoolService.java uses a guava equivalent to do this, but I think we would prefer the regular Java library rather than using guava: https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java#L50 https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java#L100 -- To view, visit http://gerrit.cloudera.org:8080/17802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6ac8cf0010c13db30219776d1d275709bf211df Gerrit-Change-Number: 17802 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 27 Sep 2021 17:28:01 +0000 Gerrit-HasComments: Yes
