Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17811 )

Change subject: POC IMPALA-9498: Allow returning arrays in select list
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17811/8/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java
File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java:

http://gerrit.cloudera.org:8080/#/c/17811/8/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@139
PS8, Line 139:       // one that calls computeMemLayout() on the parent tuple.
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/17811/8/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@334
PS8, Line 334:     String parentTupleId = (parent_ == null ? "null" : 
String.valueOf(parent_.getId().asInt()));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/17811/8/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@335
PS8, Line 335:     String itemTupleId = (itemTupleDesc_ == null ? "null" : 
String.valueOf(itemTupleDesc_.getId().asInt()));
line too long (108 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb1e42ffb21c7ddc033aba0f754b0108e46f34d0
Gerrit-Change-Number: 17811
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 04 Oct 2021 13:45:26 +0000
Gerrit-HasComments: Yes

Reply via email to