Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17778 )
Change subject: IMPALA-10862 Optimization of the code structure of TmpDir ...................................................................... IMPALA-10862 Optimization of the code structure of TmpDir Currently the logic of initialization of TmpFileMgr is a bit tedious. This patch simplifies TmpFileMgr::InitCustom() by refactoring parsing and validation logic. The patch adds TmpDirLocal, TmpDirHdfs and TmpDirS3 to inherit TmpDir to implement their own logic to parse and validate. It enables easier addition of custom logic for future filesystems. All changes only affect the interfaces within the TmpFileMgr module, and the main logic of the scratch directory parsing and verification doesn't change. Tests: Ran the Core tests and exhaustive e2e tests. Because the current testcases of TmpFileMgrTest already cover the TmpDir parsing and verification, no testcases may need to be added for this structure optimization. Added some S3 directory parsing failure testcases. Change-Id: I52971238d5841a1cdfee06b38750f9dc99a6a2be Reviewed-on: http://gerrit.cloudera.org:8080/17778 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h 4 files changed, 487 insertions(+), 328 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I52971238d5841a1cdfee06b38750f9dc99a6a2be Gerrit-Change-Number: 17778 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
