Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17904 )
Change subject: [WIP]: Initial commit ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1212 PS1, Line 1212: // 1. Should we move setting new catalogVersion out of loadTableMetadata because it doesn't line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1214 PS1, Line 1214: // 2. Should we check current catalog version for table here and only fetch a new catalogVersion instead of getting line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1215 PS1, Line 1215: // it in beginning? That way if table is already synced to latest event id, its catalogVersion is already updated line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2155 PS1, Line 2155: catalog_.getFunction(addedFn, CompareMode.IS_INDISTINGUISHABLE) != null); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2288 PS1, Line 2288: // TODO: Currently MetastoreEventsProcessor does not process update/drop stats events line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4030 PS1, Line 4030: // If 'ifNotExists' is true, add_partitions() may fail to add all the partitions to line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6896 PS1, Line 6896: private void syncToLatestHmsEvent(Table tbl) throws CatalogException, ImpalaRuntimeException { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17904/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6909 PS1, Line 6909: private void syncToLatestHmsEvent(Db db) throws CatalogException, ImpalaRuntimeException { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8af6b368f70a4cb587d2b961c059d55237b25c6c Gerrit-Change-Number: 17904 Gerrit-PatchSet: 1 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 05 Oct 2021 17:00:52 +0000 Gerrit-HasComments: Yes
