Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17894 )
Change subject: IMPALA-10950: Update expr-benchmark.cc ...................................................................... IMPALA-10950: Update expr-benchmark.cc With the introduction of PlanRootSink by IMPALA-2905, query planner has moved the scalar expression's thrift definition from 'fragments[0].output_sink.output_exprs' to 'fragments[0].plan.nodes[0].union_node.const_expr_lists[0]' for a constant query. This patch adjusts expr-benchmark.cc to generate the ScalarExpr from the right thrift location and also modify the helper class to ensure proper resource cleanup at the end of the benchmark. We explicitly set ENABLE_EXPR_REWRITES=0 to prevent expression rewrite by FoldConstantsRule.java. The benchmark used to run without codegen. This patch modifies the benchmark to run a benchmark suite both with and without codegen. Testing: - Run and verify that expr-benchmark does not crash. Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f Reviewed-on: http://gerrit.cloudera.org:8080/17894 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/expr-benchmark.cc 1 file changed, 631 insertions(+), 312 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f Gerrit-Change-Number: 17894 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
