Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17872 )
Change subject: IMPALA-10811 RPC to submit query getting stuck for AWS NLB forever ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/17872/19/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/17872/19/be/src/service/client-request-state.cc@643 PS19, Line 643: Status ClientRequestState::ExecSyncDdlRequest() { LOAD DATA might also reset metadata through CatalogOpExecutor::Exec which may not be going through ExecDdlRequest. Probably even that needs to be handled. http://gerrit.cloudera.org:8080/#/c/17872/19/be/src/service/client-request-state.cc@776 PS19, Line 776: ABORT_IF_ERROR(Thread::Create("impala-server", "async_exec_thread_", I think earlier this was not being counted for 'EXEC_TIME_LIMIT_S', but after making it async it would be counted and can breach time limit if set low. It should be added to release notes to avoid surprise. http://gerrit.cloudera.org:8080/#/c/17872/19/be/src/service/client-request-state.cc@779 PS19, Line 779: UpdateNonErrorExecState(ExecState::RUNNING); Thread spawned just above (Line 776) might finish off before the execution reaches here, in which case we might end up updating wrong state. -- To view, visit http://gerrit.cloudera.org:8080/17872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib57e86926a233ef13d27a9ec8d9c36d33a88a44e Gerrit-Change-Number: 17872 Gerrit-PatchSet: 19 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 12 Oct 2021 10:57:22 +0000 Gerrit-HasComments: Yes
