Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17858 )

Change subject: IMPALA-10923: Fine grained table refreshing at partition level 
events for transactional tables
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2944
PS3, Line 2944:       String reason, long newCatalogVersion, @Nullable 
HdfsPartition hdfsPartition) throws CatalogException {
line too long (109 > 90)


http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2741
PS3, Line 2741:       Map<Partition, HdfsPartition> hmsPartsToHdfsParts, 
boolean loadFileMetadata) throws CatalogException {
line too long (108 > 90)


http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2759
PS3, Line 2759:       loadFileMetadataForPartitions(client, 
partBuilderToPartitions.keySet(),/*isRefresh=*/true);
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1710
PS3, Line 1710:           reloadPartitions(Arrays.asList(partitionAfter_), 
false, true, "ALTER_PARTITION event");
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4232
PS3, Line 4232:   public int 
addCommittedWriteIdsAndReloadPartitionsIfExist(long eventId, String dbName, 
String tblName,
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/17858/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4233
PS3, Line 4233:       List<Long> writeIds, List<Partition> partsFromEvent, 
String reason) throws CatalogException {
line too long (99 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ba07c9a338a25614690e314335ee4b801486da9
Gerrit-Change-Number: 17858
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Fucun Chu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>
Gerrit-Comment-Date: Wed, 13 Oct 2021 19:05:19 +0000
Gerrit-HasComments: Yes

Reply via email to