Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/17735 )
Change subject: IMPALA-10414: fix memory leak when canceling the retried query ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/17735/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17735/5//COMMIT_MSG@7 PS5, Line 7: cancel > nit: cancelling Done http://gerrit.cloudera.org:8080/#/c/17735/5//COMMIT_MSG@11 PS5, Line 11: n this case, the resourc > Could you add more explanation about this? Done http://gerrit.cloudera.org:8080/#/c/17735/5/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/17735/5/be/src/runtime/query-driver.cc@357 PS5, Line 357: request_state->MarkAsRetried(retry_query_id); > Do we only need this in the corner case or we need it in all cases? Could y Done http://gerrit.cloudera.org:8080/#/c/17735/5/be/src/runtime/query-driver.cc@419 PS5, Line 419: ueryHandle* query_handle, bool ch > nit: Wait until retry_query_thread_ finishes Done -- To view, visit http://gerrit.cloudera.org:8080/17735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If804ca65da1794c819a6b2e6567ea7651ab5112f Gerrit-Change-Number: 17735 Gerrit-PatchSet: 7 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Thu, 14 Oct 2021 08:47:50 +0000 Gerrit-HasComments: Yes
