Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17929 )
Change subject: IMPALA-10957: test_iceberg_query is flaky ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17929/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17929/2//COMMIT_MSG@17 PS2, Line 17: This patch gets rid of : the DROP TABLE statement which wasn't important for the test anyway. I disagree with the solution, I would prefer to separate these tests to another .test file and call it with unique_database or to create that table during dataload. Or if a really quick solution is needed then the test could be made serial and a todo could be added to create more sophisticated solution. My understanding is that the table will be created in functional_parquet and the test won't clean it up. This can mess Impala environments up if people run the test locally and the table creation in the test changes in the future. I also have memories about tests that rely on the exact list of table in functional* databases, e.g. for SHOW TABLES. -- To view, visit http://gerrit.cloudera.org:8080/17929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16e558ae5add48d8a39bd89277a0256f534ba65f Gerrit-Change-Number: 17929 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 10:55:36 +0000 Gerrit-HasComments: Yes
