Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17860 )
Change subject: IMPALA-9873: Avoid materilization of columns for filtered out rows in Parquet table. ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc@248 PS9, Line 248: // page index are not supported for late materialization. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc@263 PS9, Line 263: && std::find(conjunct_slot_ids_.begin(), conjunct_slot_ids_.end(), slot_desc->id()) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc@2277 PS9, Line 2277: if (USES_PAGE_INDEX || !scratch_batch_->AtEnd() || num_row_to_commit == scratch_batch_->num_tuples) { line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc@2281 PS9, Line 2281: RETURN_IF_ERROR(FillScratchMicroBatches(non_filter_readers_, row_batch, skip_row_group, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17860/9/be/src/exec/parquet/hdfs-parquet-scanner.cc@2288 PS9, Line 2288: RETURN_IF_ERROR(FillScratchMicroBatches(non_filter_readers_, row_batch, skip_row_group, line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46406c913297d5bbbec3ccae62a83bb214ed2c60 Gerrit-Change-Number: 17860 Gerrit-PatchSet: 9 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 21 Oct 2021 19:18:50 +0000 Gerrit-HasComments: Yes
