Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17933 )
Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thank Sheng for the changes! I'll bump to +2 after the comments are resolved. http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java: http://gerrit.cloudera.org:8080/#/c/17933/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyCastExprRule.java@50 PS3, Line 50: nit: need one more space -- To view, visit http://gerrit.cloudera.org:8080/17933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8fac7100060d4e139a8b24d4795c6f279c55954 Gerrit-Change-Number: 17933 Gerrit-PatchSet: 3 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 26 Oct 2021 00:10:33 +0000 Gerrit-HasComments: Yes
