Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17891 )

Change subject: IMPALA-10943: Add test to verify support for multiple resource 
and executor pools
......................................................................


Patch Set 2: Code-Review+2

(4 comments)

Carrying over Andrew's +2

http://gerrit.cloudera.org:8080/#/c/17891/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/17891/1/tests/custom_cluster/test_executor_groups.py@610
PS1, Line 610:
> flake8: E122 continuation line missing indentation or outdented
Done


http://gerrit.cloudera.org:8080/#/c/17891/1/tests/custom_cluster/test_executor_groups.py@617
PS1, Line 617: "
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/17891/1/tests/custom_cluster/test_executor_groups.py@620
PS1, Line 620: "
> flake8: E251 unexpected spaces around keyword / parameter equals
Done


http://gerrit.cloudera.org:8080/#/c/17891/1/tests/custom_cluster/test_executor_groups.py@650
PS1, Line 650: s
> flake8: F841 local variable 'handle_long_running_queue2' is assigned to but
Done



--
To view, visit http://gerrit.cloudera.org:8080/17891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76d386d8de5730da937674ddd9a69aa1aa1355e
Gerrit-Change-Number: 17891
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Comment-Date: Fri, 29 Oct 2021 23:08:54 +0000
Gerrit-HasComments: Yes

Reply via email to