Sourabh Goyal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17858 )

Change subject: IMPALA-10923: Fine grained table refreshing at partition level 
events for transactional tables
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17858/11/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/17858/11/be/src/catalog/catalog-server.cc@117
PS11, Line 117:     "catalog server will refresh transactional tables 
incrementally for partition level "
nit: instead of catalog server, we should say event processor


http://gerrit.cloudera.org:8080/#/c/17858/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17858/11/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4353
PS11, Line 4353:       // set write id as committed before reload the 
partitions so that we can get
How Is this helping in getting up to date file metadata? Also what happens id 
hdfsTable.reloadPartitionsFromEvent() throws an exception? What would happen to 
the newly committed writeIds in the table? Are these writeIds give correct info 
about partition metadata?



--
To view, visit http://gerrit.cloudera.org:8080/17858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ba07c9a338a25614690e314335ee4b801486da9
Gerrit-Change-Number: 17858
Gerrit-PatchSet: 11
Gerrit-Owner: Yu-Wen Lai <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Fucun Chu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Yu-Wen Lai <[email protected]>
Gerrit-Comment-Date: Mon, 01 Nov 2021 17:49:34 +0000
Gerrit-HasComments: Yes

Reply via email to