Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: WIP IMPALA-5741: Support reading tiny RDBMS tables ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@249 PS5, Line 249: sb.append(" FROM ").append(tableConfig.get(JdbcStorageConfig.TABLE.getPropertyName())); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JethroDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JethroDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JethroDatabaseAccessor.java@21 PS5, Line 21: * JethroData specific data accessor. This is needed because JethroData JDBC drivers do not line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/OracleDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/OracleDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/OracleDatabaseAccessor.java@21 PS5, Line 21: * Oracle specific data accessor. This is needed because Oracle JDBC drivers do not support line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/OracleDatabaseAccessor.java@37 PS5, Line 37: // A simple ROWNUM > offset and ROWNUM <= (offset + limit) won't work, it will return nothing line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17842/5/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/OracleDatabaseAccessor.java@40 PS5, Line 40: + ROW_NUM_COLUMN_NAME + " >" + offset + " AND " + ROW_NUM_COLUMN_NAME + " <=" + ( line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 5 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Nov 2021 02:20:30 +0000 Gerrit-HasComments: Yes
