Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17996 )
Change subject: WIP IMPALA-11005 (part 2): Upgrade Boost library to 1.74.0 for Impala ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17996/4/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: http://gerrit.cloudera.org:8080/#/c/17996/4/be/src/runtime/timestamp-value.cc@40 PS4, Line 40: // Boost stores dates as an uint32_t. Since subtraction is needed, convert to signed. : #pragma clang diagnostic push : #pragma clang diagnostic ignored "-Wunused-const-variable" : const int64_t EPOCH_DAY_NUMBER = : static_cast<int64_t>(date(1970, boost::gregorian::Jan, 1).day_number()); : #pragma clang diagnostic pop > If this is unused, is there any reason we can't just remove it? Will remove it. -- To view, visit http://gerrit.cloudera.org:8080/17996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f32ae3c274274325e7af9e9bc9643814ae346a Gerrit-Change-Number: 17996 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Nov 2021 21:26:04 +0000 Gerrit-HasComments: Yes
