Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17897 )
Change subject: IMPALA-10940: Pick parts of recent gutil changes from Kudu repo ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/map-util.h File be/src/gutil/map-util.h: http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/map-util.h@975 PS2, Line 975: return ComputePairIfAbsentReturnAbsense<MapContainer, Function>(container, key, compute_pair_func).first; > line too long (107 > 90) fixed http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/port.h File be/src/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/port.h@1179 PS2, Line 1179: // Enable UnalignedLoad and UnalignedStore for numeric types (floats and ints) including int128. > line too long (96 > 90) fixed http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/stringprintf.h File be/src/gutil/stringprintf.h: http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/stringprintf.h@44 PS2, Line 44: extern std::string StringPrintfVector(const char* format, const std::vector<std::string>& v); > line too long (93 > 90) fixed http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/strings/numbers.cc File be/src/gutil/strings/numbers.cc: http://gerrit.cloudera.org:8080/#/c/17897/2/be/src/gutil/strings/numbers.cc@1076 PS2, Line 1076: static_cast<unsigned __int128>(10000000000) * static_cast<unsigned __int128>(10000000000); > line too long (96 > 90) fixed -- To view, visit http://gerrit.cloudera.org:8080/17897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9230923111af3c1028f0e71cd37cb5ee6fbec654 Gerrit-Change-Number: 17897 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 08 Nov 2021 22:12:10 +0000 Gerrit-HasComments: Yes
