Daniel Becker has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/18007 )

Change subject: IMPALA-11011: Impala crashes in OrcStructReader::NumElements()
......................................................................

IMPALA-11011: Impala crashes in OrcStructReader::NumElements()

Running the query

select inner_arr.ITEM
from functional_orc_def.complextypestbl_non_transactional.nested_struct.c.d.ITEM
as inner_arr;

crashes Impala because in OrcStructReader::NumElements() 'vbatch_' is
NULL and we dereference it.

This commit adds a NULL check and if 'vbatch_' is NULL, NumElements()
returns 0.

Testing:
  - added a regression test in
    
'testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test'
    that runs the above query.

Change-Id: I19cea7afdd1b3542a20a81b9f212fa320f3c1427
---
M be/src/exec/orc-column-readers.h
M 
testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list.test
2 files changed, 24 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/18007/2
--
To view, visit http://gerrit.cloudera.org:8080/18007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19cea7afdd1b3542a20a81b9f212fa320f3c1427
Gerrit-Change-Number: 18007
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>

Reply via email to