Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 )
Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/17858/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17858/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4341 PS15, Line 4341: // Aborted write id is not allowed. The write id can be committed if the table > ok. Please add a comment for it Done http://gerrit.cloudera.org:8080/#/c/17858/16/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/17858/16/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2608 PS16, Line 2608: List<HdfsPartition.FileDescriptor> FDafter = tbl.getPartitionsForNames( > From what I understand, this asserts that underlying file metatdata remaine Yes, you are right. The file descriptors will be reused if the files are not changed. I added a metric to check if file metadata is reloaded. -- To view, visit http://gerrit.cloudera.org:8080/17858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ba07c9a338a25614690e314335ee4b801486da9 Gerrit-Change-Number: 17858 Gerrit-PatchSet: 17 Gerrit-Owner: Yu-Wen Lai <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Tue, 16 Nov 2021 22:08:12 +0000 Gerrit-HasComments: Yes
